Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
We call relayers and routers in our pyth-lazer code, but sequencers and observers in our internal docs. Are we going to rename stuff in future? I went with what was written in the code for brevity. |
|
|
||
| <Callout type="info"> | ||
| The Douro Labs-operated relayer follows a strict, deterministic processing model: | ||
| - **No price dropping**: All validated updates are forwarded to the message queue without dropping any prices. |
There was a problem hiding this comment.
It's not entirely true right now. We don't drop updates entirely, but relayer can mark any update as rejected. Its logic is not fully deterministic because we still have a circuit breaker. (We plan to remove it.)
There was a problem hiding this comment.
let's describe the policy that is implemented here -- "no price dropping outside of circuit breakers"
There was a problem hiding this comment.
I was trying not to mention circuit breakers at all as we are planning to remove it.
Sequencers and observers are the names used in early docs that predate the code I think. Let's stick with relayers and routers. |
ali-behjati
left a comment
There was a problem hiding this comment.
Overall looks good, i'd approve once you apply my comments.
| - **Channel types**: Supports real-time and fixed-rate channels (1ms, 50ms, 200ms) | ||
| - **Multi-chain support**: Generates on-chain payloads for Solana, EVM, and other chains | ||
|
|
||
| #### Aggregation logic |
There was a problem hiding this comment.
this is where deterministic behaviour is important, all the aggregators produce the exact same aggregate solely relying on the consistent stream of price updates.
There was a problem hiding this comment.
here if you are not mentioning Douro running the service and think about the future that this part gets more decentralized, the publishers signature should be checked too (otherwise Douro can forge them). You can add that the aggregator validates the signatures of publisher update transactions.
p.s: we don't do it now, but will do in the future.
There was a problem hiding this comment.
So should we mention that right now?
2984901 to
3b76626
Compare
Description
Type of Change
Areas Affected
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Screenshots